LineReader class for reading lines from file stream #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| // look for the delimiter in the read data | ||
| newline_pos=(char*) memchr(current_pos, '\n', bytes_read); |
There was a problem hiding this comment.
please make this configurable, maybe even support sets of characters. you can very efficiently do this by defining a byte delimiters[256] array that has 1's at positions that should be delimiters, e.g. delimiters['\n']=1;
This would help e.g. csv parsing.
sonney2k
pushed a commit
that referenced
this pull request
Jul 6, 2013
LineReader class for reading lines from file stream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
valgrind --leak-check=full ./library_circularbuffer
==9537== Memcheck, a memory error detector
==9537== Copyright (C) 2002-2011, and GNU GPL'd, by Julian Seward et al.
==9537== Using Valgrind-3.7.0 and LibVEX; rerun with -h for copyright info
==9537== Command: ./library_circularbuffer
==9537==
==9537==
==9537== HEAP SUMMARY:
==9537== in use at exit: 0 bytes in 0 blocks
==9537== total heap usage: 241 allocs, 241 frees, 42,576 bytes allocated
==9537==
==9537== All heap blocks were freed -- no leaks are possible
==9537==
==9537== For counts of detected and suppressed errors, rerun with: -v
==9537== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 2 from 2)
valgrind --leak-check=full ./io_linereader
==9542== Memcheck, a memory error detector
==9542== Copyright (C) 2002-2011, and GNU GPL'd, by Julian Seward et al.
==9542== Using Valgrind-3.7.0 and LibVEX; rerun with -h for copyright info
==9542== Command: ./io_linereader
==9542==
==9542==
==9542== HEAP SUMMARY:
==9542== in use at exit: 0 bytes in 0 blocks
==9542== total heap usage: 374 allocs, 374 frees, 49,045 bytes allocated
==9542==
==9542== All heap blocks were freed -- no leaks are possible
==9542==
==9542== For counts of detected and suppressed errors, rerun with: -v
==9542== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 2 from 2)